Skip to content

Conversation

@arjun-rajappa
Copy link
Contributor

Publish aws lambda layers

Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
@arjun-rajappa arjun-rajappa self-assigned this Sep 8, 2025
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
@arjun-rajappa arjun-rajappa requested a review from a team September 8, 2025 05:42
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a common file which has the regions list so that we can import them in these 2 files?
This will also make it easier for us to update just this file when new regions are added for support :)

Something like (python equivalent):

cn_regions = [..]
other_regions = [....]
regions = cn_regions + other_regions

Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
@arjun-rajappa
Copy link
Contributor Author

Can we have a common file which has the regions list so that we can import them in these 2 files? This will also make it easier for us to update just this file when new regions are added for support :)

Something like (python equivalent):

cn_regions = [..]
other_regions = [....]
regions = cn_regions + other_regions

This has been incorporated

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@arjun-rajappa arjun-rajappa merged commit e96bf6b into master Sep 9, 2025
258 of 259 checks passed
@arjun-rajappa arjun-rajappa deleted the publish-aws-lambda-layers branch September 9, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants