Skip to content

fix(clients): fix metadata overwrite #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2023
Merged

fix(clients): fix metadata overwrite #26

merged 1 commit into from
Sep 28, 2023

Conversation

@heiruwu
Copy link
Contributor

@heiruwu heiruwu commented Sep 28, 2023

Because

  • metadata will be overwritten if switch instance

This commit

  • fix metada overwrite

@linear
Copy link

linear bot commented Sep 28, 2023

INS-2194 client `metadata` variable overwrite issue

@heiruwu heiruwu merged commit e332cb0 into main Sep 28, 2023
@heiruwu heiruwu deleted the heiru/ins-2194-config-secure-bool-type-conversion-issue branch September 28, 2023 10:45
@droplet-bot droplet-bot mentioned this pull request Sep 27, 2023
Merged
heiruwu pushed a commit that referenced this pull request Oct 1, 2023
@droplet-bot
chore(main): release 0.1.0 (#18)
82a4de4 
🤖 I have created a release *beep* *boop*
---


## 0.1.0 (2023-10-01)


### Features

* **auth:** adopt `Instill Core` auth
([#16](#16))
([86c0e85](86c0e85))
* **auth:** support api-token for instill cloud authentication
([#6](#6))
([e041510](e041510))
* **component,recipe:** support better component/recipe creation
([#22](#22))
([857e260](857e260))
* **config:** adopt pydantic for yaml config validation
([#9](#9))
([8903975](8903975))


### Bug Fixes

* **clients:** fix metadata overwrite
([#26](#26))
([e332cb0](e332cb0))


### Documentation

* **contributing,readme:** update docs and workflow for contributing
([#12](#12))
([6fb0c84](6fb0c84))
* **readme,notebook:** add a notebook example
([9f8d728](9f8d728))
* **readme:** add usage in README
([#24](#24))
([5af5f42](5af5f42))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🗿 instill-base

Projects

No open projects
🔮 Instill Core
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@heiruwu @droplet-bot