Skip to content

fix(client, const): add secure argument to latest SDK client #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 15, 2025
Merged

fix(client, const): add secure argument to latest SDK client #271

merged 3 commits into from
Apr 15, 2025

Conversation

@GeorgeWilliamStrong
Copy link
Contributor

@GeorgeWilliamStrong GeorgeWilliamStrong commented Apr 15, 2025

Because

  • Could not launch client for locally deployed instance as client instantiation didn't allow passing secure=False argument
  • Instill App service is deprecated
  • The SDK is currently inconsistent with the documentation which focuses on local Instill Core usage (default url="api.instill-ai.com")

This commit

  • Adds secure=False to latest SDK Python API
  • Removes deprecated Instill App service, which was giving warning messages
  • Updates HOST_URL_PROD to be `localhost:8080' for local deployment of Instill Core

@linear
Copy link

linear bot commented Apr 15, 2025

INS-7707 [Bug] Python SDK client initialisation doesn't enable setting secure=False

pinglin
pinglin approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@pinglin pinglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinglin pinglin merged commit 1355086 into main Apr 15, 2025
8 checks passed
@pinglin pinglin deleted the george/ins-7707 branch April 15, 2025 17:54
@droplet-bot droplet-bot mentioned this pull request Apr 15, 2025
Merged
@GeorgeWilliamStrong GeorgeWilliamStrong mentioned this pull request Apr 16, 2025
Closed
2 tasks
pinglin pushed a commit that referenced this pull request Apr 18, 2025
@droplet-bot
chore(main): release 0.17.0 (#262)
c7885e8 
🤖 I have created a release *beep* *boop*
---


##
[0.17.0](v0.16.2...v0.17.0)
(2025-04-15)


### Features

* **cli:** enhance CLI functionality and add Docker support
([#268](#268))
([8fa8fed](8fa8fed))
* **ray:** add high scale config
([#261](#261))
([ccf24b2](ccf24b2))


### Bug Fixes

* **client, const:** add secure argument to latest SDK client
([#271](#271))
([1355086](1355086))
* **ray:** align autoscale config
([#263](#263))
([c07b787](c07b787))
* **ray:** fix config not applied
([0bc15de](0bc15de))
* **ray:** override max replica
([7e456ca](7e456ca))
* **ray:** update high scale model config
([#264](#264))
([1086e6d](1086e6d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinglin pinglin pinglin approved these changes

Assignees

No one assigned

Labels

instill core

Projects

No open projects
🔮 Instill Core
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GeorgeWilliamStrong @pinglin @droplet-bot