Skip to content

Conversation

@heiruwu
Copy link
Contributor

@heiruwu heiruwu commented Dec 4, 2023

Because

  • add asyncio support for IO bound request tasks

This commit

  • add asyncio support in each endpoint
  • refactor client return type to align with protobuf message
  • add instance class to provide better type hinting
  • remove global client to avoid event_loop collision between sync and async clients
  • misc fixes

fixes INS-2793
fixes INS-2800
fixes INS-2142

@linear
Copy link

linear bot commented Dec 4, 2023

INS-1914 Asyncio support

@codecov
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 275 lines in your changes are missing coverage. Please review.

Comparison is base (c552f11) 45.18% compared to head (54e05ce) 43.12%.

Files Patch % Lines
instill/clients/pipeline.py 17.48% 117 Missing and 1 partial ⚠️
instill/clients/model.py 25.00% 53 Missing and 1 partial ⚠️
instill/clients/mgmt.py 23.40% 35 Missing and 1 partial ⚠️
instill/resources/model.py 4.34% 22 Missing ⚠️
instill/clients/client.py 15.78% 16 Missing ⚠️
instill/clients/instance.py 55.55% 9 Missing and 3 partials ⚠️
instill/clients/base.py 57.14% 6 Missing ⚠️
instill/resources/pipeline.py 0.00% 6 Missing ⚠️
instill/resources/connector.py 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   45.18%   43.12%   -2.07%     
==========================================
  Files          25       26       +1     
  Lines        1060     1141      +81     
  Branches      207      267      +60     
==========================================
+ Hits          479      492      +13     
- Misses        566      631      +65     
- Partials       15       18       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heiruwu heiruwu merged commit aa41246 into main Dec 4, 2023
@heiruwu heiruwu deleted the ins-1914 branch December 4, 2023 21:39
heiruwu pushed a commit that referenced this pull request Dec 11, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.4.0](v0.3.2...v0.4.0)
(2023-12-11)


### ⚠ BREAKING CHANGES

* **client:** support asyncio and add better client type hint
([#55](#55))

### Features

* **client:** support asyncio and add better client type hint
([#55](#55))
([aa41246](aa41246))
* **org:** adopt organization endpoints for VDP
([#60](#60))
([0c313d6](0c313d6))
* **ray:** add io helpers for llm tasks
([#59](#59))
([1876a20](1876a20))
* **ray:** add nested decorators
([#63](#63))
([900dda8](900dda8))
* **ray:** add text to image io helper
([#58](#58))
([0430977](0430977))


### Bug Fixes

* **clients,resources:** fix resource creating will get None type
([#57](#57))
([4516d46](4516d46))
* **makefile:** fix wheel build missing submodule
([9aa73eb](9aa73eb))
* **ray:** fix missing ray init
([#64](#64))
([db0b5c4](db0b5c4))


### Documentation

* **notebooks:** update notebooks to adopt latest ray decorators
([52b90c6](52b90c6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: 👋 Done

Development

Successfully merging this pull request may close these issues.

[INS-2142] [Feature] Add gRPC AsyncIO support in python-sdk

3 participants