Skip to content

Conversation

@heiruwu
Copy link
Contributor

@heiruwu heiruwu commented Jan 26, 2024

Because

  • GPU resource quantities > 1 must be whole numbers.

This commit

  • apply math.ceil to vram usage ratio

@codecov
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2ea4737) 28.00% compared to head (9cac404) 27.99%.

Files Patch % Lines
instill/helpers/ray_config.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   28.00%   27.99%   -0.01%     
==========================================
  Files         176      176              
  Lines        7121     7122       +1     
  Branches     1157     1157              
==========================================
  Hits         1994     1994              
  Misses       5110     5110              
- Partials       17       18       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heiruwu heiruwu merged commit 9ac7241 into main Jan 26, 2024
@heiruwu heiruwu deleted the fix-gpu-vram branch January 26, 2024 23:34
heiruwu added a commit that referenced this pull request Jan 27, 2024
Because

- GPU resource quantities > 1 must be whole numbers.

This commit

- apply math.ceil to vram usage ratio
heiruwu pushed a commit that referenced this pull request Jan 30, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.7.0](v0.6.0...v0.7.0)
(2024-01-30)


### Features

* **ray:** determine ram usage by file size
([#89](#89))
([7a0023d](7a0023d))
* **ray:** determine vram usage by file size
([#87](#87))
([71e84e6](71e84e6))


### Bug Fixes

* **ray:** add vram ceiling and override list
([#94](#94))
([5804e4a](5804e4a))
* **ray:** fix application name
([f2bb563](f2bb563))
* **ray:** fix gpu resource > 1
([#91](#91))
([b121f56](b121f56))
* **ray:** fix ray autoscaling
([#95](#95))
([5bd8c2a](5bd8c2a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: 👋 Done

Development

Successfully merging this pull request may close these issues.

3 participants