Skip to content
This repository was archived by the owner on Sep 9, 2025. It is now read-only.

Add a label access control to generate requests #118#120

Merged
russellb merged 1 commit into
instructlab:mainfrom
nerdalert:label-checks
Apr 2, 2024
Merged

Add a label access control to generate requests #118#120
russellb merged 1 commit into
instructlab:mainfrom
nerdalert:label-checks

Conversation

@nerdalert
Copy link
Copy Markdown
Collaborator

@nerdalert nerdalert commented Apr 2, 2024

  • Adds the option for a label check to generate.
  • The label is defined in the config file, if there is no label definition, the check is skipped.
  • If a generate is requested without a required label, a message is sent back to the PR rejecting the generate with the missing label name.

@nerdalert nerdalert requested a review from russellb April 2, 2024 06:58
- Adds an optional label check to generate.
- The label is defined in the config file, if there is
no label definition, the check is skipped.
- If a generate is requested without a required label,
a message is sent back to the PR rejecting the generate
with the missing label name.

Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
@nerdalert
Copy link
Copy Markdown
Collaborator Author

Example e2e. Note: there is a 10-20 second delay for the label to get reflected in the API call results with a label. Shouldn't affect anything since generally maintainers are applying the labels and users are operating the bot but worth noting in case you test it on a live repo.
image

Copy link
Copy Markdown
Collaborator

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!!

@russellb russellb merged commit 3d24542 into instructlab:main Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants