Skip to content

Conversation

@shipsing
Copy link
Contributor

@shipsing shipsing commented Jun 11, 2025

Purpose: Adds a procedure to use InstructLab with Podman Desktop

image

@shipsing
Copy link
Contributor Author

@jjasghar, Could you please review the PR? Thanks

1 similar comment
@shipsing
Copy link
Contributor Author

@jjasghar, Could you please review the PR? Thanks

shipsing added 3 commits June 27, 2025 11:08
Signed-off-by: Shipra Singh <shipsing@redhat.com>
Signed-off-by: Shipra Singh <shipsing@redhat.com>
Signed-off-by: Shipra Singh <shipsing@redhat.com>
@shipsing shipsing force-pushed the instructlab-podman-desktop-integration branch from d1bee79 to e858d6e Compare June 27, 2025 05:39
@shipsing
Copy link
Contributor Author

@dominikkawka @nimbinatus @RobotSail @nathan-weinberg, Could any of you help with the review here? Thanks

Copy link
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RobotSail
Copy link
Member

@shipsing It looks like you just need to fix the DCO on your commits

@nathan-weinberg
Copy link
Member

Didn't we remove the DCO requirement?

@RobotSail
Copy link
Member

@nathan-weinberg Good point, merging

@RobotSail RobotSail merged commit 85877f3 into instructlab:main Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants