-
Notifications
You must be signed in to change notification settings - Fork 24
UI Overview + UI Chat with LLM #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc : @instructlab/ui-maintainers |
vishnoianil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the awesome work @dominikkawka . Review and provides minor review comments.
|
|
||
| Set the `Homepage URL` and the `Authorization Callback URL` to `http://localhost:3000`. | ||
|
|
||
| Update the .env files with the new ID and secret ID generated, `OAUTH_GITHUB_ID` = Client ID, `OAUTH_GITHUB_SECRET` = Client Secret No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creation of the OAuth App will create the client_id, that is set to OAUTH_GITHUB_ID, but it doesn't automatically create the secret. Once the app is created, on the main page it provides an option to create a secret. Press the Create Secret button and it will generate a secret for you. Copy the secret and set it to OAUTH_GITHUB_SECRET value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If user don't want to setup the OAuth in his own org, we would recommend users to reach out to UI maintainers over the #ui slack channel and they will be happy to share the details of the dev OAuth app setup for the instructlab-public org for test-taxonomy.
|
|
||
|  | ||
|
|
||
| However, the model won't reply because a granite/ merlinite model endpoint hasn't been given. Instead, we will create a new custom model endpoint, using our locally hosted quantised model from step 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dominikkawka Focus of this document is dev environment or the direct users of ui.instructlab.ai? Details looks good for dev setup, but using the ui.instructlab.ai they can chat with both merlinite and granite models.
|
|
||
| You will have 3 fields to fill out | ||
|
|
||
| * The URL, where your customised model is hosted, which would be `http://127.0.0.1:8000/` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that the customized model is running where the UI is running. If it's running on different machine, it needs to be the reachable ip address of that machine. Port number should be the one where customize model serve is listening on.
|
|
||
| * The Model Name, `merlinite-7b-lab-Q4_K_M.gguf` | ||
|
|
||
| * API Key, you may put any text in here, in this case I've put in `randomCharacters` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or if user is setting up an API key, they should provide the key here.
|
|
||
| ### Taxonomy Directory Path | ||
|
|
||
| Specify where in the taxonomy this skill would belong in. As the taxonomy fills, it will become more complex, make sure to give a concise location to keep the taxonomy organised. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Specify where in the taxonomy this skill would belong in. As the taxonomy fills, it will become more complex, make sure to give a concise location to keep the taxonomy organised. | |
| Specify where in the taxonomy repository directory structure this skill would belong in. As the taxonomy fills in with more skills, it will become more complex, make sure to give a concise location to keep the taxonomy organised. |
|  | ||
|
|
||
| If you've already uploaded the markdown file to your github, you can switch to manually adding the document, and entering the `commit sha`. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be helpful if we add the snapshot of the Manually adding the doc details page.
docs/user-interface/ui_overview.md
Outdated
|
|
||
| The InstructLab User Interface (UI) is an additional component in the InstructLab project to make Knowledge/Skills | ||
| contributions more accessible to the general user. Instead of having to edit a `qna.yaml` file, | ||
| users can fill out the contribution forms on the web. The user can also view their all of their contributions in a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| users can fill out the contribution forms on the web. The user can also view their all of their contributions in a | |
| users can fill out the contribution forms on the web. The user can also view all of their contributions in a |
docs/user-interface/ui_overview.md
Outdated
| !!! note | ||
| To log into the UI and submit Knowledge and Skills contributions, you must be a member of the [instructlab-public](https://github.com/instructlab-public) github repository. | ||
|
|
||
| If you aren't a member of the repository, but still wish to experiment with the UI, we recommend you to download it locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should recommend users to reach out to UI maintainers to add them to the instructlab-public org. If they don't want to join but still want to experiment, they can set it up locally.
docs/user-interface/ui_overview.md
Outdated
|
|
||
| * Have a [github](https://github.com/) account | ||
|
|
||
| * Have InstructLab installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a mandatory requirement. This is needed only if user wants to host the endpoint locally on the same machine.
|
|
||
| When the install is finished, start the UI by running: | ||
|
|
||
| `make start-dev-local` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should mention how to stop the ui as well. User can use command make stop-dev-local to stop the dev environment.
ce4f68b to
ea334c4
Compare
Signed-off-by: DominikKawka <dkawka@redhat.com>
Signed-off-by: DominikKawka <dkawka@redhat.com>
Signed-off-by: DominikKawka <dkawka@redhat.com>
Signed-off-by: DominikKawka <dkawka@redhat.com>
Signed-off-by: DominikKawka <dkawka@redhat.com>
Signed-off-by: DominikKawka <dkawka@redhat.com>
|
I just did a flip through, this is amazing work Dom, great job. |
|
Im not an expert on the UI, but on the docs side this looks awesome to me! Great work! I think we should get this merged soon whenever its ready! 🍾 |
|
I dropped the ball on reviewing it again, but the content looks great!. Thanks for pulling this together @dominikkawka . I pushed a PR to UI repo as well, that points to this brand new documentation. Awesome work, you rock !! |
Still have to write a section on skills/ knowledge contributions and being able to view them, would like some feedback on what I've currently written also.