Update from_litellm type hints to properly return AsyncInstructor

[jonchun]

Type Checking was previously failing when attempting to create an AsyncInstructor because litellm.acompletion is actually of type Callable[..., Awaitable[Any]] and not Awaitable. This was causing the type hinter to match on Callable[..., Any]. With these changes, the type hints properly return AsyncInstructor.

e.g.

from litellm import acompletion, completion
import instructor

client = instructor.from_litellm(completion) # (variable) client: Instructor
aclient = instructor.from_litellm(acompletion) # (variable) aclient: AsyncInstructor

---

Important

Update from_litellm type hints to correctly return AsyncInstructor for async completions.

• Type Hints:
  • Update from_litellm overloads to use Callable[..., Awaitable[Any]] for async completions and Callable[..., Any] for sync completions.
  • Ensure from_litellm returns AsyncInstructor for async completions and Instructor for sync completions.

^{This description was created by for acf2563. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to acf2563 in 41 seconds

More details

• Looked at 33 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. instructor/client.py:561

• Draft comment:
  Using inspect.iscoroutinefunction may not cover all asynchronous cases, such as coroutine objects. Consider using asyncio.iscoroutinefunction or checking for Awaitable to ensure accurate type inference.
• Reason this comment was not posted:
  Confidence changes required: 80%
  The PR correctly updates the type hints for the from_litellm function to distinguish between synchronous and asynchronous completions. However, the implementation of from_litellm uses inspect.iscoroutinefunction to determine if the function is asynchronous, which may not cover all cases, such as when the function is a coroutine but not defined with async def. This could lead to incorrect type inference.

2. instructor/client.py:544

• Draft comment:
  The overloads for from_litellm are inconsistent with the implementation. The first overload should be for Callable[..., Any] returning Instructor, and the second for Callable[..., Awaitable[Any]] returning AsyncInstructor. This matches the logic in the implementation where inspect.iscoroutinefunction determines the return type.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

Workflow ID: wflow_QjN2oTmrAnnuQ7wU

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[jonchun]

Forgot to mention that the actual return types were correct, it was just the type hints that were incorrect.

is_async = inspect.iscoroutinefunction(completion)

correctly identifies that acompletion is an async function.

[ivanleomk]

Looks good to me, approved and merging in