Skip to content

Commit f0a6a21

Browse files
Fix unit tests
1 parent 7d7347b commit f0a6a21

File tree

1 file changed

+13
-11
lines changed

1 file changed

+13
-11
lines changed

Core/CoreTests/Features/AudioVideo/UploadMediaTests.swift

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -86,19 +86,20 @@ class UploadMediaTests: CoreTestCase {
8686
func testCompleteUploadSuccess() {
8787
let context = Context(.course, id: "1")
8888
let expectation = XCTestExpectation(description: "callback was called")
89-
let response = PostCompleteMediaUploadRequest.Response(media_object: .init(media_id: "10"))
89+
let response = PostCompleteMediaUploadRequest.Response(media_object: .init(media_id: "10", attachment_id: "34"))
9090
api.mock(PostCompleteMediaUploadRequest(mediaID: "1", context: context, type: .audio), value: response)
9191
var error: Error?
92-
var mediaID: String?
92+
var entry: MediaEntry?
9393
let upload = UploadMedia(type: .audio, url: URL(string: "data:text/plain,abcde")!, context: context)
9494
upload.callback = {
95-
mediaID = $0
95+
entry = $0
9696
error = $1
9797
expectation.fulfill()
9898
}
9999
upload.completeUpload(mediaID: "10")
100100
wait(for: [expectation], timeout: 1)
101-
XCTAssertEqual(mediaID, "10")
101+
XCTAssertEqual(entry?.mediaID, "10")
102+
XCTAssertEqual(entry?.attachmentID, "34")
102103
XCTAssertNil(error)
103104
}
104105

@@ -107,35 +108,36 @@ class UploadMediaTests: CoreTestCase {
107108
let expectation = XCTestExpectation(description: "callback was called")
108109
api.mock(PostCompleteMediaUploadRequest(mediaID: "1", context: context, type: .audio), error: NSError.internalError())
109110
var error: Error?
110-
var mediaID: String?
111+
var entry: MediaEntry?
111112
let upload = UploadMedia(type: .audio, url: URL(string: "data:text/plain,abcde")!, context: context)
112113
upload.callback = {
113-
mediaID = $0
114+
entry = $0
114115
error = $1
115116
expectation.fulfill()
116117
}
117118
upload.completeUpload(mediaID: "10")
118119
wait(for: [expectation], timeout: 1)
119-
XCTAssertNil(mediaID)
120+
XCTAssertNil(entry)
120121
XCTAssertNotNil(error)
121122
}
122123

123124
func testCompleteUploadNoContext() {
124125
let context = Context(.course, id: "1")
125126
let expectation = XCTestExpectation(description: "callback was called")
126-
let response = PostCompleteMediaUploadRequest.Response(media_object: .init(media_id: "1"))
127+
let response = PostCompleteMediaUploadRequest.Response(media_object: .init(media_id: "1", attachment_id: "23"))
127128
api.mock(PostCompleteMediaUploadRequest(mediaID: "1", context: context, type: .audio), value: response)
128129
var error: Error?
129-
var mediaID: String?
130+
var entry: MediaEntry?
130131
let upload = UploadMedia(type: .audio, url: URL(string: "data:text/plain,abcde")!, context: nil)
131132
upload.callback = {
132-
mediaID = $0
133+
entry = $0
133134
error = $1
134135
expectation.fulfill()
135136
}
136137
upload.completeUpload(mediaID: "2")
137138
wait(for: [expectation], timeout: 1)
138-
XCTAssertEqual(mediaID, "2")
139+
XCTAssertEqual(entry?.mediaID, "2")
140+
XCTAssertNil(entry?.attachmentID)
139141
XCTAssertNil(error)
140142
}
141143
}

0 commit comments

Comments
 (0)