Skip to content

Conversation

@int128
Copy link
Owner

@int128 int128 commented Oct 9, 2021

This will fix the failed test:

=== RUN   TestTLS
    server.go:36: oauth2cli: starting a server at 127.0.0.1:37285
    client.go:43: could not open browser request: could not send a request: Get "https://localhost:37285": x509: certificate has expired or is not yet valid: current time 2021-10-09T13:24:46Z is after 2020-09-23T10:33:00Z
2021/10/09 13:24:46 http: TLS handshake error from 127.0.0.1:42704: remote error: tls: bad certificate
    server.go:66: oauth2cli: shutting down the server
    server.go:70: oauth2cli: force-closing the server: shutdown failed: context deadline exceeded
    server.go:42: oauth2cli: stopped the server
    tls_test.go:69: could not get a token: authorization error: authorization error: context deadline exceeded
--- FAIL: TestTLS (1.00s)

I regenerated certificates using https://github.com/int128/kubelogin/blob/master/integration_test/keypair/testdata/Makefile.

@int128 int128 marked this pull request as ready for review October 9, 2021 13:29
@int128 int128 merged commit 3ab5a50 into master Oct 9, 2021
@int128 int128 deleted the fix-test branch October 9, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants