Fix IndexLastListElement issues on assignments and var/out #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirras
requested changes
Feb 26, 2025
Collaborator
cirras
left a comment
cirras
left a comment
There was a problem hiding this comment.
Looks good, can we get a CHANGELOG entry?
fourls
force-pushed
the
list-last-assignment
branch
from
4be1a6d to
52442b4
Compare
Collaborator
Author
|
Oops! Forgot the changelog. |
cirras
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates IndexLastListElement to ignore the left-hand side of expression statements. This is a current false-positive, since
TList.Lastis a function and is not eligible to be assigned to.