Fix analysis errors around type of types
#363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fourls
requested changes
Apr 14, 2025
Collaborator
fourls
left a comment
fourls
left a comment
There was a problem hiding this comment.
Looks good for the most part.
| } | ||
|
|
||
| @Override | ||
| public TypeReferenceNode getTypeOfTypeNode() { |
Collaborator
There was a problem hiding this comment.
Should this be getTypeReferenceNode? Isn't this the type of type node?
Collaborator
Author
There was a problem hiding this comment.
Agreed that this is confusing. The naming was intended to be symmetrical with ClassReferenceNode::getClassOfTypeNode, but that's not especially important.
Let's go with getTypeReferenceNode.
Collaborator
Author
|
And integration tests are failing again... |
fourls
approved these changes
Apr 17, 2025
Collaborator
fourls
left a comment
fourls
left a comment
There was a problem hiding this comment.
Looks good! I'm not going to worry about the ITs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
ClassCastExceptioninTypeOfTypeNode::createTypeclass of)Fixes #361.