feat: allow forking added to the repository settings #2885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add allow_forking schema field (optional, no default) - Implement conditional logic to only set allow_forking for non-public repos - Add conditional read to only store allow_forking in state for non-public repos - Add comprehensive acceptance tests with skipUnlessMode helper - Update existing repository tests to include allow_forking Fixes integrations#353
Contributor
pascal-hofmann
left a comment
pascal-hofmann
left a comment
There was a problem hiding this comment.
Doc updates are missing. Is this intentional?
Collaborator
Author
|
Hey @pascal-hofmann no they haven't been. I will update those! I also wasn't sure if this conflicts with the changes you introduced in your PR. How should we incorporate those? |
Contributor
|
Hi @pmartindev, Can you have a look at #1649? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #353
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!