Skip to content

Fix crash when flushing events to disk at exit. #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Fix crash when flushing events to disk at exit. #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/gpgmm/TraceEvent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ namespace gpgmm {

TraceEvent::TraceEvent(char phase,
TraceEventCategory category,
const char* name,
const std::string& name,
uint64_t id,
uint32_t tid,
double timestamp,
Expand Down
4 changes: 2 additions & 2 deletions src/gpgmm/TraceEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ namespace gpgmm {
public:
TraceEvent(char phase,
TraceEventCategory category,
const char* name,
const std::string& name,
uint64_t id,
uint32_t tid,
double timestamp,
Expand All @@ -165,7 +165,7 @@ namespace gpgmm {

char mPhase = 0;
TraceEventCategory mCategory;
const char* mName = nullptr;
std::string mName;
uint64_t mID = 0;
uint32_t mTID = 0;
double mTimestamp = 0;
Expand Down