Skip to content

Fix ASSERT in CreateBufferOversized. #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2022
Merged

Fix ASSERT in CreateBufferOversized. #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc84962
Fixup comment under MemoryAllocator::TrySubAllocateMemory.
bbernhar May 13, 2022
8f2880f
Fix ASSERT in CreateBufferOversized.
bbernhar May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/gpgmm/common/MemoryAllocator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,9 @@ namespace gpgmm {
ASSERT(memory != nullptr);
memory->Ref();

// Calling memory allocator must be responsible in fully initializing the memory
// allocation. This is because we do not yet know how to map the sub-allocated block to
// memory.
// Caller is be responsible in fully initializing the memory allocation.
// This is because TrySubAllocateMemory() does not necessarily know how to map the
// final sub-allocated block to created memory.
return std::make_unique<MemoryAllocation>(nullptr, memory, kInvalidOffset,
AllocationMethod::kUndefined, block);
}
Expand Down
2 changes: 1 addition & 1 deletion src/gpgmm/d3d12/ResourceHeapAllocatorD3D12.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ namespace gpgmm { namespace d3d12 {
ComPtr<ID3D12Heap> heap;
HRESULT hr = mDevice->CreateHeap(&heapDesc, IID_PPV_ARGS(&heap));
if (FAILED(hr)) {
ErrorEvent(GetTypename()) << " failed to create heap: " << GetErrorMessage(hr);
InfoEvent(GetTypename()) << " failed to create heap: " << GetErrorMessage(hr);
return {};
}

Expand Down