Fix ALLOCATION_FLAG_ALWAYS_CACHE_SIZE from disabling sub-allocation. #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbernhar
force-pushed
the
size_cache
branch
2 times, most recently
from
6c20119 to
aa11c32
Compare
Flag value specified by GPGMM was wrong, which resulted in sub-allocation being disabled. Also, cached sizes did not apply to sub-allocation within which may be unexpected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag specified by GPGMM was wrong, which resulted in sub-allocation being disabled. Also, cached sizes did not apply to sub-allocating within a resource which may be unexpected.
This change fixes the incorrectly specified flag value, re-enables the size cache for small textures, and adds tests.