Move size-aware LinkedList into seperate type. #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, LinkedList has two different usages. The first usage was meant for fast random (non-iterator) based insertion, the second usage was non-random insertion where the size was known. This splits the latter usage into a seperate type, SizedLinkedList. This change fixed a corner case bug with the slab list size() where de-allocate incorrectly assumed the slab size was always equal to the memory size.
github-actions
bot
added
D3D12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, LinkedList has two different usages. The first usage was meant for fast random (non-iterator) based insertion, the second usage was non-random insertion where the size was known. This splits the latter usage into a seperate type, SizedLinkedList.
This change also identified a corner case bug where de-allocate incorrectly assumed the slab size was always equal to the memory size.