Skip to content

Depreciate ResidencyManager::InsertHeap and ResidencyManager::Evict. #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2022
Merged

Depreciate ResidencyManager::InsertHeap and ResidencyManager::Evict. #521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 5 additions & 18 deletions src/gpgmm/d3d12/ResidencyManagerD3D12.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,24 +178,6 @@ namespace gpgmm::d3d12 {
*/
HRESULT UnlockHeap(Heap* heap);

/** \brief Add or insert the specify heap.

Inserting a heap means to have it managed by this residency manager.

@param heap A pointer to the heap being managed.
*/
HRESULT InsertHeap(Heap* heap);

/** \brief Evict memory per segment.

Evicts until the budget is under the specified size.

@param evictSizeInBytes Target size, in bytes, to be under budget.
@param memorySegmentGroup Memory segment to evict from.
*/
HRESULT Evict(uint64_t evictSizeInBytes,
const DXGI_MEMORY_SEGMENT_GROUP& memorySegmentGroup);

/** \brief Execute command lists using residency managed heaps.

Submits an array of command lists and residency sets for the specified command queue.
Expand Down Expand Up @@ -259,10 +241,15 @@ namespace gpgmm::d3d12 {

ResidencyManager(const RESIDENCY_DESC& descriptor, std::unique_ptr<Fence> fence);

HRESULT Evict(uint64_t evictSizeInBytes,
const DXGI_MEMORY_SEGMENT_GROUP& memorySegmentGroup);

HRESULT EvictInternal(uint64_t evictSizeInBytes,
const DXGI_MEMORY_SEGMENT_GROUP& memorySegmentGroup,
uint64_t* evictedSizeInBytesOut = nullptr);

HRESULT InsertHeap(Heap* heap);

HRESULT InsertHeapInternal(Heap* heap);

const char* GetTypename() const;
Expand Down