Skip to content

Conversation

@bbernhar
Copy link
Contributor

@bbernhar bbernhar commented Aug 1, 2022

Replaces use of LinkedList with StableList. To achieve this, a seperate list is maintained on the cache to de-allocate a slab from either list, inserted slab-blocks are now copyable, and the extra indirection of slab's allocation was removed.

@github-actions github-actions bot added the Frontend Changes to common or GPU API agnostic code. label Aug 1, 2022
@bbernhar bbernhar force-pushed the stable_slab branch 2 times, most recently from 13112c9 to 31cf886 Compare August 3, 2022 01:29
@github-actions github-actions bot added the Test Changes in tests. label Aug 3, 2022
@bbernhar bbernhar changed the title Eliminate use of LinkedList from slab allocation. Eliminate LinkedList from slab allocation. Aug 3, 2022
@bbernhar bbernhar requested a review from bjjones August 3, 2022 17:09
@bbernhar
Copy link
Contributor Author

bbernhar commented Aug 3, 2022

@bjjones Could you PTAL? Appreciate it.

Copy link
Contributor

@bjjones bjjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Replaces use of LinkedList with StableList. To achieve this, a seperate list is maintained on the cache to de-allocate a slab from either list, inserted slab-blocks are now copyable, and the extra indirection of slab's allocation was removed.
@bbernhar bbernhar merged commit 6b9f725 into main Aug 4, 2022
@bbernhar bbernhar deleted the stable_slab branch August 4, 2022 17:58
bbernhar added a commit that referenced this pull request Aug 5, 2022
…554)"

WebNN is reporting a CRT leak after this change.

This reverts commit 6b9f725.
bbernhar added a commit that referenced this pull request Aug 5, 2022
bbernhar added a commit that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend Changes to common or GPU API agnostic code. Test Changes in tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants