Fix ASSERT generation from not evaluating the condition during release builds. #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e builds. The ASSERT code-generator incorrectly checks if __builtin_assume exists. Once fixed, clang incorrectly assumes all functions have side effects and emits a warning. To avoid these warnings, __builtin_assume was replaced with __builtin_unreachable, since the generated code was equivelent.
github-actions
bot
added
the
Frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ASSERT code-generator incorrectly checks if __builtin_assume exists. Once fixed, clang incorrectly assumes all functions have side effects and emits a warning. To avoid these warnings, __builtin_assume was replaced with __builtin_unreachable, since the generated code was equivelent.