Remove default-initialization from D3D descriptor structures. #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbernhar
force-pushed
the
default_init
branch
2 times, most recently
from
4673513 to
a7a0c25
Compare
This is because `desc = {}` could zero-initialize them to mean a unexpected default-value. More precisely,
* RESIDENCY_DESC::MinLogLevel assumes corruption-level messages by default.
* ALLOCATOR_DESC::SubAllocationAlgorithm and ALLOCATOR_DESC::PoolAlgorithm use ALLOCATOR_ALGORITHM_DEFAULT, which internally is set to slab + segmented pool.
Support for a minimum viable implementation #577
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because
desc = {}could zero-initialize them to mean a unexpected default-value. More precisely,Support for a minimum viable implementation #577