Skip to content

Report budget change amounts to debug log. #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Report budget change amounts to debug log. #610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion src/gpgmm/d3d12/ResidencyManagerD3D12.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ namespace gpgmm::d3d12 {
}

gpgmm::DebugEvent("ResidencyManager", EventMessageId::BudgetUpdate)
<< "Updated GPU budget from OS notification.";
<< "Recieved budget update event from OS.";
break;
}
// mUnregisterAndExitEvent
Expand Down Expand Up @@ -418,14 +418,46 @@ namespace gpgmm::d3d12 {
static_cast<uint64_t>(queryVideoMemoryInfoOut.Budget * mMinPctOfBudgetToReserve),
pVideoMemoryInfo->AvailableForReservation);

const uint64_t oldUsage = pVideoMemoryInfo->CurrentUsage;
pVideoMemoryInfo->CurrentUsage =
queryVideoMemoryInfoOut.CurrentUsage - pVideoMemoryInfo->CurrentReservation;

if (oldUsage > pVideoMemoryInfo->CurrentUsage) {
gpgmm::DebugLog() << ((memorySegmentGroup == DXGI_MEMORY_SEGMENT_GROUP_NON_LOCAL)
? "Dedicated"
: "Shared")
<< " GPU memory usage went down by "
<< GPGMM_BYTES_TO_MB(oldUsage - pVideoMemoryInfo->CurrentUsage) << " MBs.";
} else if (oldUsage < pVideoMemoryInfo->CurrentUsage) {
gpgmm::DebugLog() << ((memorySegmentGroup == DXGI_MEMORY_SEGMENT_GROUP_NON_LOCAL)
? "Dedicated"
: "Shared")
<< " GPU memory usage went up by "
<< GPGMM_BYTES_TO_MB(pVideoMemoryInfo->CurrentUsage - oldUsage) << " MBs.";
}

// If we're restricting the budget, leave the budget as is.
if (!mIsBudgetRestricted) {
const uint64_t oldBudget = pVideoMemoryInfo->Budget;
pVideoMemoryInfo->Budget = static_cast<uint64_t>(
(queryVideoMemoryInfoOut.Budget - pVideoMemoryInfo->CurrentReservation) *
mMaxPctOfVideoMemoryToBudget);

if (oldBudget > pVideoMemoryInfo->Budget) {
gpgmm::DebugLog() << ((memorySegmentGroup == DXGI_MEMORY_SEGMENT_GROUP_NON_LOCAL)
? "Dedicated"
: "Shared")
<< " GPU memory budget went down by "
<< GPGMM_BYTES_TO_MB(oldBudget - pVideoMemoryInfo->Budget)
<< " MBs.";
} else if (oldBudget < pVideoMemoryInfo->Budget) {
gpgmm::DebugLog() << ((memorySegmentGroup == DXGI_MEMORY_SEGMENT_GROUP_NON_LOCAL)
? "Dedicated"
: "Shared")
<< " GPU memory budget went up by "
<< GPGMM_BYTES_TO_MB(pVideoMemoryInfo->Budget - oldBudget)
<< " MBs.";
}
}

// Ignore when no budget was specified.
Expand Down