Prevent backend leak detection from not reporting leaks. #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Build
* Moves backend leak detection enabling to ALLOCATOR_FLAG_NEVER_LEAK_MEMORY. * Moves front-end leak detection checks to build flag. * Disables front-end leaks checks via GPGMM_ENABLE_ALLOCATOR_LEAK_CHECKS. This change prevents front-end checks from conflicting with the backend checks since the same build flag was used to enable both and the backend checks could not report leaks first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue of front-end checks conflicting with the backend checks since the same build flag was used to enable both and the backend checks could not report leaks first. Since memory leaking can now be checked by front-end tests (via MemoryAllocator::GetInfo), always checking is not needed by default.