Remove usage of std::function in MVI

[bjjones]

Removes usage of a callback using std::function in favor of a C-style function pointer callback.

[bjjones]

This hasn't been tested. What is the best way to test the MVI? Building the WIP DML Backend patch right now to try testing with the full thing.

I'm a little unsure if I got the ComPtr operations correct - it's been awhile.

[bbernhar]

This hasn't been tested. What is the best way to test the MVI?

Probably need to come up with a end2end test specifically for the MVI (really basic), and perhaps re-use it for the Chromium CL.

[bbernhar]

Approach LGTM + left some comments.

[bbernhar]

Dawn integration patch will also need to be updated too. Just apply the https://github.com/intel/GPGMM/blob/main/.github/workflows/.patches/dawn.diff to a local (Dawn) repo, modify it, then save the new diff. I keep the Dawn bot going for API coverage.

[bjjones]

Is the dawn.patch supposed to apply cleanly to top-of-tree Dawn? I'm getting multiple conflicts and even more errors when I try to build.

[bbernhar]

Is the dawn.patch supposed to apply cleanly to top-of-tree Dawn? I'm getting multiple conflicts and even more errors when I try to build.

Possibly but it's currently based on https://github.com/intel/GPGMM/blob/main/scripts/dawn.deps (be4c9f48aaef9f2144a654a847b76a6a0050ec5b).

[bbernhar]

LGTM + after fixes.

[bjjones]

I'm getting hung up on updating the dawn.diff. It applies cleanly on the version you've stated, but I then I get a number of build errors. I also need to be using near top of tree GPGMM if I want to apply this CreateHeap change - and the build errors only get worse after that.

[bbernhar]

I'm getting hung up on updating the dawn.diff. It applies cleanly on the version you've stated, but I then I get a number of build errors. I also need to be using near top of tree GPGMM if I want to apply this CreateHeap change - and the build errors only get worse after that.

Normally I just edit + commit diff and let the builder do its thing. Otherwise, the steps to build locally are here: https://github.com/intel/GPGMM/blob/main/.github/workflows/win_dawn_rel.yaml. Typically, a git checkout followed by gclient sync is all I need.

[bbernhar]

@bjjones Thanks!