Skip to content

Document MVI MemoryAllocation Lifetime #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2022
Merged

Document MVI MemoryAllocation Lifetime #681

merged 1 commit into from
Oct 26, 2022

Conversation

@bjjones
Copy link
Contributor

@bjjones bjjones commented Oct 25, 2022

Per request on the Chromium CL.

@bjjones bjjones requested a review from bbernhar October 25, 2022 18:40
@bjjones
Copy link
Contributor Author

bjjones commented Oct 25, 2022

Just verifying I got this right.

bbernhar
bbernhar reviewed Oct 25, 2022
View reviewed changes
bbernhar
bbernhar approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@bbernhar bbernhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

@bjjones
Copy link
Contributor Author

bjjones commented Oct 26, 2022

Seems fine to me.

So does that mean merge as-is?

@bbernhar
Copy link
Contributor

bbernhar commented Oct 26, 2022 •
edited
Loading

So does that mean merge as-is?

SGTM.

@bjjones bjjones merged commit eae2524 into intel:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbernhar bbernhar bbernhar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bjjones @bbernhar