Skip to content

Fix leak when importing resources without allocation. #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2022
Merged

Fix leak when importing resources without allocation. #694

merged 1 commit into from
Dec 10, 2022

Conversation

@bbernhar
Copy link
Contributor

@bbernhar bbernhar commented Dec 10, 2022

Calling CreateResource(resource, nullptr) would leak because the heap being created was never freed.

@bbernhar bbernhar enabled auto-merge (squash) December 10, 2022 02:19
@github-actions github-actions bot added the D3D12 DirectX 12 Backend Change label Dec 10, 2022
@bbernhar bbernhar added the bug Something isn't working label Dec 10, 2022
@bbernhar bbernhar merged commit e85f824 into main Dec 10, 2022
@bbernhar bbernhar deleted the leak_fix branch December 10, 2022 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working D3D12 DirectX 12 Backend Change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bbernhar