Skip to content

Minor refactor to prepare for release. #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2023
Merged

Minor refactor to prepare for release. #716

merged 1 commit into from
Jan 12, 2023

Conversation

@bbernhar
Copy link
Contributor

@bbernhar bbernhar commented Jan 12, 2023

  • Move GetTypename scope to private.
  • Move resource heap name into static section.
  • Rename ImportResourceCallbackContext::CreateHeap to ImportResourceCallbackContext::GetHeap.
  • Nothing gets created during import so the method name should reflect that.

@bbernhar bbernhar enabled auto-merge (squash) January 12, 2023 20:30
@github-actions github-actions bot added D3D12 DirectX 12 Backend Change Frontend Changes to common or GPU API agnostic code. labels Jan 12, 2023
@bbernhar bbernhar merged commit b49ee5f into main Jan 12, 2023
@bbernhar bbernhar deleted the tmp8 branch January 12, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

D3D12 DirectX 12 Backend Change Frontend Changes to common or GPU API agnostic code.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bbernhar