Skip to content

Reuse sub-allocation instead of re-creating. #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Reuse sub-allocation instead of re-creating. #934

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/gpgmm/common/MemoryAllocator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,14 +249,17 @@ namespace gpgmm {
allocatedMemoryResult.AcquireResult();
ASSERT(memoryAllocation->GetMemory() != nullptr);

// Increment the sub-allocation count so the sub-allocator knows when to
// safely deallocate the underlying memory allocation.
memoryAllocation->GetMemory()->Ref();

// Caller is be responsible in fully initializing the memory allocation.
// This is because TrySubAllocateMemory() does not necessarily know how to map the
// final sub-allocated block to created memory.
return std::make_unique<MemoryAllocationBase>(
nullptr, memoryAllocation->GetMemory(), kInvalidOffset,
AllocationMethod::kUndefined, block, requestSize);
memoryAllocation->SetBlock(block);
memoryAllocation->SetMethod(AllocationMethod::kUndefined);

return memoryAllocation;
}

void InsertIntoChain(ScopedRef<MemoryAllocatorBase> next);
Expand Down