make component loader event group formation deterministic for post-processing #517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event group ordering must be consistent for the metrics post-processing (--input) feature to work.
This pull request refactors the metrics loader component for improved determinism and maintainability. The main changes focus on removing unused filtering logic and ensuring deterministic processing and grouping of metric events.
Refactoring and code cleanup:
filterUncollectableMetrics
andidentifyUncollectableEvents
functions, as well as their usage, simplifying the metric loading process by assuming all events are collectable. [1] [2]Deterministic processing:
loadEventDefinitions
to ensure a consistent and deterministic order when processing event definition files.mergeSmallGroups
to be deterministic, including a panic for empty groups and consistent tie-breaking.Dependency updates:
io/fs
import to support directory entry sorting.