-
Notifications
You must be signed in to change notification settings - Fork 53
Add network interface coalesce settings collection via ethtool -c #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: harp-intel <78619061+harp-intel@users.noreply.github.com>
Co-authored-by: harp-intel <78619061+harp-intel@users.noreply.github.com>
Co-authored-by: harp-intel <78619061+harp-intel@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot remove files from PR that are not required to be changed
|
@copilot address code review change requests |
Co-authored-by: harp-intel <78619061+harp-intel@users.noreply.github.com>
Addressed all code review feedback in commit ee25bc1. Removed go.sum changes and the internal/script/resources/ directory files (.gitkeep and placeholder.txt) which were not required for this PR. The PR now contains only the 4 essential files for the ethtool coalesce settings feature. |
Implementation complete for adding ethtool coalesce settings collection:
ethtool -coutputSummary
Added collection of network interface coalesce settings using
ethtool -cto PerfSpect reports. This addresses the issue request to collect coalesce settings includingtx-usecswhich is important for network-intensive, CPU-bound workloads.Key Changes:
ethtool -cfor each interfaceFiles Changed:
internal/script/script_defs.go- Added ethtool -c collectioninternal/report/table_helpers.go- Added struct fields and parsing logicinternal/report/table_defs.go- Added display columnsinternal/report/table_helpers_test.go- Added test coverageBackward Compatibility:
ethtool -cis not supportedAll tests pass, no security issues detected, and code follows project standards.
Original prompt
Fixes #85
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.