-
Notifications
You must be signed in to change notification settings - Fork 53
Add Card/Port column to NIC table for physical card mapping #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: harp-intel <78619061+harp-intel@users.noreply.github.com>
Co-authored-by: harp-intel <78619061+harp-intel@users.noreply.github.com>
Co-authored-by: harp-intel <78619061+harp-intel@users.noreply.github.com>
|
@copilot Order the fields: |
Co-authored-by: harp-intel <78619061+harp-intel@users.noreply.github.com>
Reordered the NIC table fields to match the requested layout in commit 428ae02. The field order is now:
|
harp-intel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot address change requests
Co-authored-by: harp-intel <78619061+harp-intel@users.noreply.github.com>
Addressed all change requests:
All tests continue to pass. |
Implementation Complete ✅
Successfully implemented the Card/Port mapping feature for the NIC table as requested in issue #522.
Changes Addressed
Removed files that should not be tracked in the resources directory:
.keep,placeholder.txt, and.gitignorefrominternal/script/resources/go.sumto its original state.gitignoreto excludeREADME.mdfrom resources directoryREADME.mdfor the embed to work, and the subdirectoriesx86_64andaarch64which are ignored by gitField Order
The NIC table fields are ordered as requested:
Quality Assurance
✅ All tests pass
✅ Code formatted with gofmt
✅ Build succeeds
✅ No security vulnerabilities (CodeQL scan)
✅ BSD-3-Clause license headers included
✅ Minimal, surgical changes
✅ Backward compatible
✅ No breaking changes
Original prompt
Fixes #377
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.