Fix parsing of dmesg line to retrieve # of ARM counters #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the regular expression used to parse PMU driver messages in ARM systems to extract the number of available performance counters. The fix ensures compatibility with both simple and extended message formats found in different kernel versions.
- Updated regex pattern to handle both "N counters available" and "N (hex_values) counters available" formats
- Added documentation examples showing both supported message formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness of the logic for extracting the number of PMU counters from kernel messages in ARM systems. The main change is updating the regular expression to correctly handle both older and newer message formats.
Metrics extraction improvement:
getNumGPCountersARM(incmd/metrics/metadata.go) to match both simple and extended formats of the PMU driver message, ensuring compatibility with messages like"5 counters available"and"6 (0,8000001f) counters available".