fix lscpu parsing for older versions of lscpu #533
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness of the cache parsing logic for
lscpuoutput, ensuring compatibility with both modern and legacy formats where numeric fields may be represented as strings. It also adds comprehensive tests to validate correct parsing across various scenarios.Parsing improvements for
lscpucache outputlscpuoutput formats by introducing a newlscpuCacheEntryLegacystruct intable_helpers_cache.go, allowing the parser to handle cases where numeric fields are returned as strings.parseLscpuCacheOutputfunction to first attempt parsing with the modern format, and if that fails, to fall back to the legacy format. Legacy string fields are converted to integers, with invalid or empty strings defaulting to zero.Testing enhancements
testifyassertions and requirements totable_helpers_cache_test.gofor more expressive and reliable test checks.TestParseLscpuCacheOutputfunction intable_helpers_cache_test.go, covering a wide range of input scenarios including modern and legacy formats, empty fields, invalid number strings, empty input, invalid JSON, and empty caches arrays.