Skip to content

fix: don't check for PMUs in use if noroot flag given #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2025
Merged

fix: don't check for PMUs in use if noroot flag given #541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions cmd/metrics/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1147,20 +1147,22 @@ func prepareTarget(targetContext *targetContext, localTempDir string, localPerfP
var err error
_ = statusUpdate(myTarget.GetName(), "configuring target")
// are PMUs being used on target?
if family, err := myTarget.GetFamily(); err == nil && cpus.IsIntelCPUFamilyStr(family) {
output, err := script.RunScript(myTarget, script.GetScriptByName(script.PMUBusyScriptName), localTempDir)
if err != nil {
err = fmt.Errorf("failed to check if PMUs are in use: %w", err)
_ = statusUpdate(myTarget.GetName(), fmt.Sprintf("Error: %v", err))
targetContext.err = err
channelError <- targetError{target: myTarget, err: err}
return
}
for line := range strings.SplitSeq(output.Stdout, "\n") {
// if one of the PMU MSR registers is active, then the PMU is in use (ignore cpu_cycles)
if strings.Contains(line, "Active") && !strings.Contains(line, "0x30a") {
slog.Warn("PMU is in use on target", slog.String("target", myTarget.GetName()), slog.String("line", line))
_ = statusUpdate(myTarget.GetName(), "Warning: PMU in use, see log for details")
if !flagNoRoot {
if family, err := myTarget.GetFamily(); err == nil && cpus.IsIntelCPUFamilyStr(family) {
output, err := script.RunScript(myTarget, script.GetScriptByName(script.PMUBusyScriptName), localTempDir)
if err != nil {
err = fmt.Errorf("failed to check if PMUs are in use: %w", err)
_ = statusUpdate(myTarget.GetName(), fmt.Sprintf("Error: %v", err))
targetContext.err = err
channelError <- targetError{target: myTarget, err: err}
return
}
for line := range strings.SplitSeq(output.Stdout, "\n") {
// if one of the PMU MSR registers is active, then the PMU is in use (ignore cpu_cycles)
if strings.Contains(line, "Active") && !strings.Contains(line, "0x30a") {
slog.Warn("PMU is in use on target", slog.String("target", myTarget.GetName()), slog.String("line", line))
_ = statusUpdate(myTarget.GetName(), "Warning: PMU in use, see log for details")
}
}
}
}
Expand Down