fix: some uncore metric values incorrect #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
…o misreport event values Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect uncore metric values by improving the group merging logic. The changes ensure duplicate events are properly handled and that groups are merged as thoroughly as possible through an iterative approach.
Key Changes:
- Adds deduplication pass to remove duplicate events across uncore groups before merging
- Implements iterative merging loop that continues until no more groups can be merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the logic in the
MergeUncoreGroupsfunction withincmd/metrics/loader_perfmon_group_uncore.goto improve how duplicate events are handled and to optimize the merging process of uncore groups. The main improvements are the elimination of duplicate events before merging and a more robust merging loop that continues until no further merges are possible.Deduplication of events:
UncoreGroupinstances and remove duplicate events from theirGeneralPurposeCounters, ensuring each event appears only in one group. Debug logging is included to track removals.Merging process improvements:
mergedflag to continue merging as long as changes are made.