Skip to content

Support omp threadpool #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2025
Merged

Support omp threadpool #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5dc0862
support omp threadpool
dian-lun-lin Aug 13, 2025
ba454f7
Merge branch 'main' into omp
dian-lun-lin Aug 13, 2025
aea8b84
revie to make the option consistent
dian-lun-lin Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@ include("cmake/fmt.cmake")
include("cmake/spdlog.cmake")
include("cmake/toml.cmake")

if(SVS_ENABLE_OMP)
include("cmake/openmp.cmake")
endif()

add_library(svs_x86_options_base INTERFACE)
add_library(svs::x86_options_base ALIAS svs_x86_options_base)
if(CMAKE_SYSTEM_PROCESSOR MATCHES "(x86)|(X86)|(amd64)|(AMD64)")
Expand Down
6 changes: 2 additions & 4 deletions cmake/openmp.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,8 @@
# limitations under the License.

find_package(OpenMP)
if (OPENMP_FOUND)
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${OpenMP_C_FLAGS}")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${OpenMP_CXX_FLAGS}")
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${OpenMP_EXE_LINKER_FLAGS}")
if (OPENMP_CXX_FOUND)
target_link_libraries(${SVS_LIB} INTERFACE OpenMP::OpenMP_CXX)
else()
message(FATAL_ERROR "no OpenMP support")
endif()
Expand Down
11 changes: 11 additions & 0 deletions cmake/options.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,11 @@ option(SVS_INITIALIZE_LOGGER
ON # enabled by default
)

option(SVS_ENABLE_OMP
"Support OpenMP threadpool."
OFF # disable by default
)

#####
##### Experimental
#####
Expand Down Expand Up @@ -140,6 +145,12 @@ else()
target_compile_options(${SVS_LIB} INTERFACE -DSVS_INITIALIZE_LOGGER=0)
endif()

if (SVS_ENABLE_OMP)
target_compile_options(${SVS_LIB} INTERFACE -DSVS_ENABLE_OMP=1)
else()
target_compile_options(${SVS_LIB} INTERFACE -DSVS_ENABLE_OMP=0)
endif()

#####
##### Helper target to apply relevant compiler optimizations.
#####
Expand Down
27 changes: 27 additions & 0 deletions include/svs/lib/threads/threadpool.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@
#include <sstream>
#include <vector>

SVS_VALIDATE_BOOL_ENV(SVS_ENABLE_OMP);
#if SVS_ENABLE_OMP
#include <omp.h>
#endif

#include "svs/lib/numa.h"
#include "svs/lib/threads/thread.h"
#include "svs/lib/threads/thunks.h"
Expand Down Expand Up @@ -283,6 +288,28 @@ class SwitchNativeThreadPool {
NativeThreadPool threadpool_;
};

SVS_VALIDATE_BOOL_ENV(SVS_ENABLE_OMP);
#if SVS_ENABLE_OMP
/////
///// A thread pool that utilizes OpenMP for multithreading
/////
class OMPThreadPool {
public:
explicit OMPThreadPool(size_t num_threads) { omp_set_num_threads(num_threads); }

size_t size() const { return omp_get_num_threads(); }

void parallel_for(std::function<void(size_t)> f, size_t n) {
#pragma omp parallel for
for (size_t i = 0; i < n; ++i) {
f(i);
}
}

void resize(size_t num_threads) { omp_set_num_threads(num_threads); }
};
#endif

/////
///// A handy reference wrapper for situations where we only want to share a thread pool
/////
Expand Down
Loading