fix multiple devices issue in Compressor and AutoScheme #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
fix #1004 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…o-round into fix_multi_device_issue
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues related to handling multiple devices by refactoring device parsing logic and memory management. The changes improve device list handling throughout the codebase and ensure proper memory cleanup across multiple GPU devices.
Key changes:
- Renamed
parse_all_available_devicetoparse_available_devicesfor consistency - Enhanced
clear_memoryfunctions to accept adevice_listparameter for multi-device synchronization - Replaced
is_complex_device_mappingchecks withlen(self.device_list) > 1for clearer logic
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| auto_round/utils/device.py | Enhanced device parsing with dict-like string support, refactored memory clearing to handle multiple devices, and renamed device parsing function |
| auto_round/compressors/base.py | Added device_list initialization and propagated it through all clear_memory calls, replaced complex device mapping checks with device list length checks |
| auto_round/auto_scheme/utils.py | Updated import and function call to use renamed parse_available_devices |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
for more information, see https://pre-commit.ci
mengniwang95
approved these changes
Nov 7, 2025
for more information, see https://pre-commit.ci
wenhuach21
changed the title
…o-round into fix_multi_device_issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.