-
Notifications
You must be signed in to change notification settings - Fork 58
Fix act calibration bug #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch, could you help add an UT?
for more information, see https://pre-commit.ci
|
auto-round/auto_round/compressors/base.py Line 1956 in 7e43385
it should be matched and converted to full name |
test/test_cpu/test_autoround.py
Outdated
| "self_attn": {"bits": 4, "data_type": "mx_fp", "act_bits": 4, "act_data_type": "mx_fp", "group_size": 32} | ||
| } | ||
| autoround = AutoRound( | ||
| self.model, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please just pass the self.model_name in the future, better not use the same model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
test/test_cpu/test_autoround.py
Outdated
| layer_config=layer_config, | ||
| amp=False, | ||
| ) | ||
| autoround.quantize_and_save(self.save_folder, inplace=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if call save, then delete the folder after the ut
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
@wenhuach21 CI has passed, can we merge this PR? |
Bug fix