🎨 Improve STATIC_ASSERT
#167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - Writing `STATIC_ASSERT(cond, str)` means that `str` has to be formatted either as a separate variable or inline in the call. Solution: - Allow `STATIC_ASSERT(cond, fmt_str, args...)` where the string is formatted automatically. Notes: - Each argument must still be wrapped in `CX_VALUE`. Because there is no generic equivalent of `transform` for `__VA_ARGS__`. - A bug in clang (for which a workaround is in place) was discovered: llvm/llvm-project#114234 - `CX_VALUE` has been made more workable with GCC. GCC did not allow the `struct` definition inside the macro.
mjcaisse-intel
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
STATIC_ASSERT(cond, str)means thatstrhas to be formatted either as a separate variable or inline in the call.Solution:
STATIC_ASSERT(cond, fmt_str, args...)where the string is formatted automatically.Notes:
CX_VALUE. Because there is no generic equivalent oftransformfor__VA_ARGS__.CX_VALUEhas been made more workable with GCC. GCC did not allow thestructdefinition inside the macro.