Skip to content

🎨 Make bitset::lowest_unset work correctly with enumerations #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elbeno merged 1 commit into from
Feb 19, 2025
Merged

🎨 Make bitset::lowest_unset work correctly with enumerations #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/stdx/bitset.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,16 +341,16 @@ class bitset {
return n + static_cast<std::size_t>(popcount(highbits()));
}

[[nodiscard]] constexpr auto lowest_unset() const -> std::size_t {
[[nodiscard]] constexpr auto lowest_unset() const {
std::size_t i = 0;
for (auto e : storage) {
if (auto offset = static_cast<std::size_t>(countr_one(e));
offset != std::numeric_limits<elem_t>::digits) {
return i + offset;
return static_cast<iter_arg_t>(i + offset);
}
i += std::numeric_limits<elem_t>::digits;
}
return i;
return static_cast<iter_arg_t>(i);
}

[[nodiscard]] constexpr auto operator~() const -> bitset {
Expand Down
5 changes: 5 additions & 0 deletions test/bitset.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,11 @@ TEST_CASE("use bitset with enum struct (transform_reduce)", "[bitset]") {
bs));
}

TEST_CASE("use bitset with enum struct (lowest_unset)", "[bitset]") {
constexpr auto bs = stdx::bitset<Bits::MAX>{stdx::place_bits, Bits::ZERO};
CHECK(bs.lowest_unset() == Bits::ONE);
}

#if __cplusplus >= 202002L
TEST_CASE("construct with a ct_string", "[bitset]") {
using namespace stdx::literals;
Expand Down
Loading