Skip to content

fix: fixed quiet_mode test to ignore unimportant logs #3795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 8, 2024
Merged

fix: fixed quiet_mode test to ignore unimportant logs #3795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6da80b
fix: fixed quiet_mode test to ignore unimportant logs
inosmeet Feb 6, 2024
199d207
fix: improve quiet_mode to ignore unimportant logs
inosmeet Feb 7, 2024
436c005
change disabling configuration
inosmeet Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cve_bin_tool/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,7 @@ def main(argv=None):
LOGGER.setLevel(args["log_level"].upper())

if args["quiet"]:
logging.disable(logging.ERROR)
LOGGER.setLevel(logging.CRITICAL)

if 0 < LOGGER.level <= 10:
Expand Down
1 change: 0 additions & 1 deletion test/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@ def test_unknown_warning(self, caplog):
assert len(warnings) > 0, "Unknown version warning didn't get generated"
assert f"png was detected with version UNKNOWN in file {filename}" in warnings

@pytest.mark.skip(reason="Causing problems during longtests, needs fixing")
def test_quiet_mode(self, capsys, caplog):
"""Test that an quiet mode isn't generating any output"""

Expand Down