Skip to content

Conversation

@terriko
Copy link
Contributor

@terriko terriko commented Feb 22, 2024

This adds a tarfile with an absolute path file in it for testing, and tweaks behaviour on windows so it will use an external tar program to extract to a specified directory if such a program is available.

@terriko
Copy link
Contributor Author

terriko commented Feb 22, 2024

Note for self: the linux tests are failing even on main and need investigation but there's no new failures here. My attempt at a windows fix is causing all the windows tests that use extraction to fail, though, so that's clearly not working and needs adjustment (although the short-term adjustment may be "make sure tar is installed and we can find it" rather than in this code)

@terriko terriko added the awaiting maintainer Need a maintainer to respond / help out label Feb 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 80.37%. Comparing base (d6cbe40) to head (b1f0d13).
Report is 106 commits behind head on main.

Files Patch % Lines
cve_bin_tool/extractor.py 57.89% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3849      +/-   ##
==========================================
+ Coverage   75.41%   80.37%   +4.95%     
==========================================
  Files         808      820      +12     
  Lines       11983    12371     +388     
  Branches     1598     1676      +78     
==========================================
+ Hits         9037     9943     +906     
+ Misses       2593     2004     -589     
- Partials      353      424      +71     
Flag Coverage Δ
longtests 80.37% <66.66%> (+4.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terriko
Copy link
Contributor Author

terriko commented Mar 19, 2024

Current setup (running local tar/7z on windows) is passing 98% of tests and then timing out., so I'm upping the windows timeouts to see if it actually can complete to inform what we do next.

@terriko
Copy link
Contributor Author

terriko commented Mar 19, 2024

Still stopped at 98% with higher limit, so there's a coding issue that's causing this rather than just a timeout.

@terriko terriko mentioned this pull request Mar 20, 2024
@terriko
Copy link
Contributor Author

terriko commented Mar 21, 2024

Closing this in favour of a new PR with only the windows experiment in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting maintainer Need a maintainer to respond / help out

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants