-
Notifications
You must be signed in to change notification settings - Fork 574
fix: add absolute tarfile test, windows workaround #3849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Terri Oda <terri.oda@intel.com>
|
Note for self: the linux tests are failing even on main and need investigation but there's no new failures here. My attempt at a windows fix is causing all the windows tests that use extraction to fail, though, so that's clearly not working and needs adjustment (although the short-term adjustment may be "make sure tar is installed and we can find it" rather than in this code) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3849 +/- ##
==========================================
+ Coverage 75.41% 80.37% +4.95%
==========================================
Files 808 820 +12
Lines 11983 12371 +388
Branches 1598 1676 +78
==========================================
+ Hits 9037 9943 +906
+ Misses 2593 2004 -589
- Partials 353 424 +71
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Current setup (running local tar/7z on windows) is passing 98% of tests and then timing out., so I'm upping the windows timeouts to see if it actually can complete to inform what we do next. |
|
Still stopped at 98% with higher limit, so there's a coding issue that's causing this rather than just a timeout. |
|
Closing this in favour of a new PR with only the windows experiment in it. |
This adds a tarfile with an absolute path file in it for testing, and tweaks behaviour on windows so it will use an external tar program to extract to a specified directory if such a program is available.