Skip to content

test: OSV ecosystems to check for missing and extra ecosytems #3882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2024
Merged

test: OSV ecosystems to check for missing and extra ecosytems #3882

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e89222
test: Updated OSV source test for updating the ecosystems
cinix Feb 28, 2024
0051864
test: Added back removed pytest skipif statement
cinix Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 14 additions & 31 deletions test/test_source_osv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

import aiohttp
import pytest
import requests

from cve_bin_tool.data_sources import osv_source

Expand All @@ -27,36 +28,7 @@ def teardown_class(cls):
shutil.rmtree(cls.osv.cachedir)

osv_url = "https://osv-vulnerabilities.storage.googleapis.com/"

ecosystems = [
"Android",
"DWF",
"Debian",
"Debian:10",
"Debian:11",
"Debian:3.0",
"Debian:3.1",
"Debian:4.0",
"Debian:5.0",
"Debian:6.0",
"Debian:7",
"Debian:8",
"Debian:9",
"GSD",
"Go",
"Hex",
"JavaScript",
"Linux",
"Maven",
"NuGet",
"OSS-Fuzz",
"Packagist",
"PyPI",
"RubyGems",
"UVI",
"crates.io",
"npm",
]
ecosystems_url = "https://osv-vulnerabilities.storage.googleapis.com/ecosystems.txt"

zip_namelist = [
"GSD-2021-1000000.json",
Expand Down Expand Up @@ -198,7 +170,18 @@ def teardown_class(cls):
async def test_update_ecosystems(self):
await self.osv.update_ecosystems()

assert all(x in self.osv.ecosystems for x in self.ecosystems)
ecosystems_txt = requests.get(self.ecosystems_url, timeout=300).text.strip("\n")
expected_ecosystems = set(ecosystems_txt.split("\n"))

# Because ecosystems.txt does not contain the complete list, this must be
# manually fixed up.
expected_ecosystems.add("DWF")
expected_ecosystems.add("JavaScript")

# Assert that there are no missing ecosystems
assert all(x in self.osv.ecosystems for x in expected_ecosystems)
# Assert that there are no extra ecosystems
assert all(x in expected_ecosystems for x in self.osv.ecosystems)

@pytest.mark.asyncio
@pytest.mark.skipif(not EXTERNAL_SYSTEM(), reason="Needs network connection.")
Expand Down