Set 'source' field of diagnostics according to the analysis source

[JonatanWaern]

Allows to differentiate errors from other extensions
(and between analysis and linting)

Signed-off-by: Jonatan Waern jonatan.waern@intel.com

[JonatanWaern]

I am a bit conflicted on what is suitable to report as source. ATM I report as "dls-analysis" or "dls-lint" which is useful for people who known what the 'dls' is. But it is of little use to people who may want to identify which extension causes the error report (in which case we should probably use or even . However not only does that get quite long as a source identifier, the DLS is supposed to be client-agnostic, so adding the extension name in the source makes little sense.

[TSonono]

Another option is dmlc for analysis and dml-lint for lint. Even though these terms might not be 100 % correct, I think they could perhaps be easier to understand for a user? It's also client agnostic

[JonatanWaern]

Another option is dmlc for analysis and dml-lint for lint. Even though these terms might not be 100 % correct, I think they could perhaps be easier to understand for a user? It's also client agnostic

I do not think "dmlc" is an improvement over "dls". but "dml" might be? so we could use "dml" and "dml-lint". "dml" should be vaguely understandable by a lay-editor (since they are in a .dml file, after all) and from there they need to make the jump that dml diagnostics come from the simics modelling extension, which is still a jump (albeit a small one).

[TSonono]

Another option is dmlc for analysis and dml-lint for lint. Even though these terms might not be 100 % correct, I think they could perhaps be easier to understand for a user? It's also client agnostic

I do not think "dmlc" is an improvement over "dls". but "dml" might be? so we could use "dml" and "dml-lint". "dml" should be vaguely understandable by a lay-editor (since they are in a .dml file, after all) and from there they need to make the jump that dml diagnostics come from the simics modelling extension, which is still a jump (albeit a small one).

I'm OK with that 👍

[TSonono]

Thanks for adding this so quickly!