Do not use git2 #167
Merged
Do not use git2 #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git2 requires openssl-sys, which does not compile as portably as we'd like Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
There was a problem hiding this comment.
Pull Request Overview
This PR removes the dependency on git2 due to portability concerns with its transitive dependency openssl-sys. The implementation switches from using git repository indexing to filesystem walking for finding files with specific extensions in tests.
Key Changes:
- Replaced
git2::Repositorywithwalkdir::WalkDirfor file discovery - Removed
git2from Cargo.toml dependencies - Updated function name from
get_indexed_files_with_extensiontoget_files_with_extension
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/file_tests.rs | Replaced git index-based file discovery with filesystem walking using walkdir |
| Cargo.toml | Removed git2 dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TSonono
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git2 requires openssl-sys, which does not compile as portably as we'd like
Signed-off-by: Jonatan Waern jonatan.waern@intel.com