Added ELFERROR #82
Merged
Added ELFERROR #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Tests fail on python3.7 because of a problem with the importlib_metadata package. The issue was fixed using the workaround suggsted here: python/importlib_metadata#406 (comment)
tomersa
commented
Oct 3, 2022
| typing-extensions>=4.1.0 | ||
| pyelftools~=0.28 | ||
| packaging~=21.2 | ||
| importlib_metadata~=4.8 |
Contributor
Author
There was a problem hiding this comment.
That was added in order to pass the tests (They were broken on master because of this import). See the comment below from the commit for more details:
* Tests fail on python3.7 because of a problem with the importlib_metadata package.
The issue was fixed using the workaround suggested here: https://github.com/python/importlib_metadata/issues/406#issuecomment-1264682770
Contributor
There was a problem hiding this comment.
Well the issue is actually with flake8, so I wouldn't put this in the requirements.txt, I'd put a pip install for this in the CI workflow.
Contributor
Author
There was a problem hiding this comment.
DanielShaulov
approved these changes
Oct 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed as part of another PR.