-
Notifications
You must be signed in to change notification settings - Fork 16
Refactor the deep tile matmul config and skip the single-iteration loop generation #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| innerMostKBlockCandidates = {16, 32, 64}; | ||
| innerMostNBlockCandidates = {16, 32, 64}; | ||
| NBlockCandidates = innerMostNBlockCandidates; | ||
| KBlockCandidates = innerMostKBlockCandidates; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So after the change here, innermost Kblock will only be one of 16/32/64 if allowIndivisibleInnerblock is true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, your understanding is correct
073ec23 to
0c56c7d
Compare
0c56c7d to
01920b6
Compare
|
|
||
| inline void getDimTypeFromIterators(linalg::LinalgOp linalgOp, | ||
| SmallVectorImpl<DimType> &dimTypes) { | ||
| SmallVector<utils::IteratorType> iteratorTypes = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explicitly specify mlir::utils::IteratorType here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add mlir namespace here
|
Overall LGTM, do you think we should add a single simple case to cover the case of skipping single-iteration loop generation? |
This test could cover this case. The file check will check two
|
|
Please help to rebase the code base, then we can merge it. |
The code has been rebased now |
Track: #288