Remove conv weight scale reciprocal #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jgong5 @Xia-Weiwen, could you help to take a look of this PR? |
jgong5
approved these changes
Aug 18, 2023
Yes, we need to merge PR: pytorch/pytorch#105996 firstly before update PyTorch IDeep to this commit. |
|
Hi @yanbing-j, could you help to merge it? |
leslie-fang-intel
added a commit
to pytorch/pytorch
that referenced
this pull request
Aug 18, 2023
…tion in QConv PT2E" **Summary** After oneDNN 3.1 upgrade, we don't need do the weight scale reciprocal calculation. So, remove the duplicated reciprocal calculation to optimize QConv performance. Change to new IDeep Commit after IDeep PR: intel/ideep#222 landed. cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 gujinghui PenghuiCheng jianyuh min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen [ghstack-poisoned]
leslie-fang-intel
added a commit
to pytorch/pytorch
that referenced
this pull request
Aug 18, 2023
**Summary** After oneDNN 3.1 upgrade, we don't need do the weight scale reciprocal calculation. So, remove the duplicated reciprocal calculation to optimize QConv performance. Change to new IDeep Commit after IDeep PR: intel/ideep#222 landed. cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 gujinghui PenghuiCheng jianyuh min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen [ghstack-poisoned]
leslie-fang-intel
added a commit
to pytorch/pytorch
that referenced
this pull request
Aug 19, 2023
…tion in QConv PT2E" **Summary** After oneDNN 3.1 upgrade, we don't need do the weight scale reciprocal calculation. So, remove the duplicated reciprocal calculation to optimize QConv performance. Change to new IDeep Commit after IDeep PR: intel/ideep#222 landed. cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 gujinghui PenghuiCheng jianyuh min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen [ghstack-poisoned]
leslie-fang-intel
added a commit
to pytorch/pytorch
that referenced
this pull request
Aug 19, 2023
**Summary** After oneDNN 3.1 upgrade, we don't need do the weight scale reciprocal calculation. So, remove the duplicated reciprocal calculation to optimize QConv performance. Change to new IDeep Commit after IDeep PR: intel/ideep#222 landed. cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 gujinghui PenghuiCheng jianyuh min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen [ghstack-poisoned]
leslie-fang-intel
added a commit
to pytorch/pytorch
that referenced
this pull request
Aug 21, 2023
…ndant QConv weight scale reciprocal calculation" **Summary** Upgrade IDeep, the only diff IDeep change is this IDeep PR: intel/ideep#222 which has done 2 things: - Remove the redundant QConv weight scale reciprocal calculation. - Pump IDEEP_VERSION_REVISION version from 0 to 1. So only QConv related calculation will be impacted and we already use IDeep version API in #105996 to make the corresponding change in PyTorch. cc gujinghui PenghuiCheng XiaobingSuper jianyuh jgong5 mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen [ghstack-poisoned]
leslie-fang-intel
added a commit
to pytorch/pytorch
that referenced
this pull request
Aug 21, 2023
…ht scale reciprocal calculation" **Summary** Upgrade IDeep, the only diff IDeep change is this IDeep PR: intel/ideep#222 which has done 2 things: - Remove the redundant QConv weight scale reciprocal calculation. - Pump IDEEP_VERSION_REVISION version from 0 to 1. So only QConv related calculation will be impacted and we already use IDeep version API in #105996 to make the corresponding change in PyTorch. cc gujinghui PenghuiCheng XiaobingSuper jianyuh jgong5 mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen [ghstack-poisoned]
leslie-fang-intel
added a commit
to pytorch/pytorch
that referenced
this pull request
Aug 23, 2023
…ndant QConv weight scale reciprocal calculation" **Summary** Upgrade IDeep which includes 2 IDeep change as IDeep PR: intel/ideep#222 and intel/ideep#223 - For IDeep PR: intel/ideep#222 which has done 2 things: - Remove the redundant QConv weight scale reciprocal calculation. - Pump IDEEP_VERSION_REVISION version from 0 to 1. So only QConv related calculation will be impacted and we already use IDeep version API in #105996 to make the corresponding change in PyTorch. - For IDeep PR: intel/ideep#223 which includes AArch64 specific changes with the oneDNN 3.1.1 upgrade. cc gujinghui PenghuiCheng XiaobingSuper jianyuh jgong5 mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen [ghstack-poisoned]
leslie-fang-intel
added a commit
to pytorch/pytorch
that referenced
this pull request
Aug 23, 2023
…ht scale reciprocal calculation" **Summary** Upgrade IDeep which includes 2 IDeep change as IDeep PR: intel/ideep#222 and intel/ideep#223 - For IDeep PR: intel/ideep#222 which has done 2 things: - Remove the redundant QConv weight scale reciprocal calculation. - Pump IDEEP_VERSION_REVISION version from 0 to 1. So only QConv related calculation will be impacted and we already use IDeep version API in #105996 to make the corresponding change in PyTorch. - For IDeep PR: intel/ideep#223 which includes AArch64 specific changes with the oneDNN 3.1.1 upgrade. cc gujinghui PenghuiCheng XiaobingSuper jianyuh jgong5 mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After oneDNN 3.1 upgrade, we don't need do the weight scale reciprocal calculation. So, remove the duplicated reciprocal calculation to optimize QConv performance.