Skip to content

Conversation

@mythi
Copy link
Contributor

@mythi mythi commented Nov 21, 2022

draft until v0.13.1 becomes available.

Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
@mythi mythi marked this pull request as ready for review November 21, 2022 17:18
Copy link

@oreillymj oreillymj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@bart0sh bart0sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bart0sh
Copy link
Member

bart0sh commented Nov 22, 2022

@mythi looks like 0.13.1 is already available: https://console.cloud.google.com/gcr/images/kubebuilder/GLOBAL/kube-rbac-proxy

feel free to merge when needed

@mythi
Copy link
Contributor Author

mythi commented Nov 22, 2022

@mythi looks like 0.13.1 is already available: https://console.cloud.google.com/gcr/images/kubebuilder/GLOBAL/kube-rbac-proxy

feel free to merge when needed

yes we can merge now. Now that the operator is deployed part of the tests, this PR was failing until 0.13.1 became available.

@tkatila tkatila merged commit ce4ae42 into intel:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants